-
Notifications
You must be signed in to change notification settings - Fork 796
[UR] Add UR_L0_V2_DISABLE_ZE_LAUNCH_KERNEL_WITH_ARGS debugging variable #20703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
[UR] Add UR_L0_V2_DISABLE_ZE_LAUNCH_KERNEL_WITH_ARGS debugging variable #20703
Conversation
876f5c0 to
e96c7cf
Compare
e96c7cf to
ce0487c
Compare
ce0487c to
74c718b
Compare
|
CI failure (UR L0v2) is caused by #20683 |
Add UR_L0_V2_DISABLE_ZE_LAUNCH_KERNEL_WITH_ARGS debugging environment variable to disable calling ZeCommandListAppendLaunchKernelWithArguments(). Signed-off-by: Lukasz Dorau <[email protected]>
|
@intel/dpcpp-doc-reviewers please review |
sycl/doc/EnvironmentVariables.md
Outdated
| | Environment variable | Values | Description | Adapter Support | | ||
| | -------------------- | ------ | ----------- | --------------- | | ||
| | `UR_L0_V2_FORCE_DISABLE_COPY_OFFLOAD` | Integer | By default, copy operations submitted to any queue can be offloaded to dedicated copy engines. Setting this variable instructs the driver to keep all copy operations on the engine behind the original queue. The default value is 0. | V2 | | ||
| | `UR_L0_V2_DISABLE_ZE_LAUNCH_KERNEL_WITH_ARGS` | Integer | By default, ZeCommandListAppendLaunchKernelWithArguments() will be called when available and possible. Setting this variable instructs the adapter to not call ZeCommandListAppendLaunchKernelWithArguments() and use the old path using ZeCommandListAppendLaunchKernel(). The default value is 0. | V2 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | `UR_L0_V2_DISABLE_ZE_LAUNCH_KERNEL_WITH_ARGS` | Integer | By default, ZeCommandListAppendLaunchKernelWithArguments() will be called when available and possible. Setting this variable instructs the adapter to not call ZeCommandListAppendLaunchKernelWithArguments() and use the old path using ZeCommandListAppendLaunchKernel(). The default value is 0. | V2 | | |
| | `UR_L0_V2_DISABLE_ZE_LAUNCH_KERNEL_WITH_ARGS` | Integer | By default, `zeCommandListAppendLaunchKernelWithArguments()` will be called when available and possible. Setting this variable instructs the adapter to not call `zeCommandListAppendLaunchKernelWithArguments()` and use the old path using `zeCommandListAppendLaunchKernel()`. The default value is 0. | V2 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
sycl/doc/EnvironmentVariables.md
Outdated
| | Environment variable | Values | Description | Adapter Support | | ||
| | -------------------- | ------ | ----------- | --------------- | | ||
| | `UR_L0_V2_FORCE_DISABLE_COPY_OFFLOAD` | Integer | By default, copy operations submitted to any queue can be offloaded to dedicated copy engines. Setting this variable instructs the driver to keep all copy operations on the engine behind the original queue. The default value is 0. | V2 | | ||
| | `UR_L0_V2_DISABLE_ZE_LAUNCH_KERNEL_WITH_ARGS` | Integer | By default, ZeCommandListAppendLaunchKernelWithArguments() will be called when available and possible. Setting this variable instructs the adapter to not call ZeCommandListAppendLaunchKernelWithArguments() and use the old path using ZeCommandListAppendLaunchKernel(). The default value is 0. | V2 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "will be called when available and possible" mean? When is it available but it isn't possible to call it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool RunNewPath =
!DisableZeLaunchKernelWithArgs && KernelWithArgsSupported &&
(!cooperativeKernelLaunchRequested ||
(cooperativeKernelLaunchRequested && CooperativeCompatible));
if (RunNewPath) {but I think we can remove when available and possible and leave just: By default, zeCommandListAppendLaunchKernelWithArguments() will be called - is it OK for you?
steffenlarsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording of the env var is awfully technical, but I suppose it's no different than some of the others.
Add
UR_L0_V2_DISABLE_ZE_LAUNCH_KERNEL_WITH_ARGSdebugging environment variable to disable callingZeCommandListAppendLaunchKernelWithArguments().